I visited Israel about 6 years ago. It was safe then, but I wonder about now. I didn't find the landscape especially appealing. Jerusalem (the old city) was amazing. Many photo opts. There were armed Israeli soldiers on about every corner. They were very friendly. In th Arab section, they were friendly to tourists, but it seemed clear they were friendly to the business, not the people.
If you wat to photograph historical of religeous sites, this has to be the place. There are "digs" everywhere, and they are quite open. We did get run off at gun point at the excavation of the old walls of Jerico. Never really felt threatened but it was an Uzi in the hands of a very humorless Palestinian.
I have mixed feeling about returning now. On the one hand, I think it would be dangerous. On the other hand, think it is about as good as it will ever be. So if you really want to se Israel, I'd go now.