Trump never divested himself from his business interests by placing them in a blind trust, and some of them (for example, the hotel in the Old Post Office Building in Washington and several of the resort properties) clearly are profiting from his being in public office. That is an actual conflict of interest, not the appearance of a conflict.
I actually see some logic in Trump's decision not to divest. Given the sprawling nature of his family business and the fact that it involves the ownership or brand-management of many real estate properties, placing all the assets under the control of independent trustees would have been complicated and, unless the trustees sold off the real estate, an ineffective way to insulate him from continuing to personally profit from the patronage of the properties by individuals or groups seeking favorable treatment from his Administration. But that in no way alters the reality that he has a conflict of interest.
You're right there is an appearance of conflict of interest. But what should the country do with rich people who own properties and biusinesses around the world who want to be president? Should they be forced to sell everything they own? It would be a fire sale and they'd never be able to do it without going bankrupt. No president is asked to give up his livelihood. It would be unfair to do that to any American. Even if you force him to sell if he becomes president, he will be accused of selling things for higher then they're worth as people pay more looking for favors from him. So there are really no simple answers.
Also, if harsh rules were placed on presidents, they would eliminate very smart and capable businessmen who could be fine presidents. Experienced people who know how to manage and get things done, a valuable asset in a president. We would eliminate some of the best people for the job. We'd be shooting ourselves in the foot.
Now Trump has done some insulation. He's not handling day-to-day operations. That's what billionaire Mayor Bloomberg did in NYC when he was mayor. It's not a perfect arrangement. But it's legal for the president and mayor.