i bought a 5d , but im struggling to get good photos .
im new to photog , took a 6 month course on cameras and photography and did ok .
but i cannot seem to get good colours or photos out of this , is it to old ?
There is not a camera in the world that is TOO OLD. As long as it functions correctly, you should be able to get good photos. Now, newer DSLRs will give more dynamic range, better ISO performance, less shadow noise, etc.
I'm a Nikon guy, but recommend you factory reset the camera. I believe their is a Clear Settings menu in the 5D
In the menu. Setup section (Yellow), there's a "Clear Settings" section that allows you to:
Clear all camera settings
Clear all custom functions
Clear registered camera settings
I would also check with Canon for the latest firmware updates and install those.
Then starting from this base, see what you get. You didn't give a good indication of the subjects and lighting conditions under which you are shooting. Bad color could be as simple as using the wrong white balance setting. Starting with the Auto setting would help.