I agree with Howard Smith, Gettysburg is really a great place for photography. I have a son who works at Gettysburg College and I visit there very often. The battlefields all around the area have the most amazing wooden fences...
It is very true that the Amish people don't like to be photographed so that's always complicated and risky to go there and not find something to photograph.
However, if you do go to Gettysburg,you have several interesting options----- you can then work your way north on 15 which has lovely stretches along the Susquehanna River after Harrisburg, and then continue on 15 to Williamsport and north towards Rochester. This is the slow way... Otherwise you can go north from Gettysburg on Interstate 81 North towards Hazleton, Scranton, towards Syracuse and you have several State Parks on the way, Poconos, waterfalls, to explore and eventually also some architecture in Syracuse or cross over on 17 to 14 and go up to the lakes through the small roads instead of the big ones.
I personally like the area around the lakes, Lake Seneca in particular. There are so many vineyards, old barns, in that area- Route 14 in particular. If you like architecture, I was going to suggest.. Buffalo. I was told that there is an amazing old part of town for that. I was actually supposed to go yesterday for an opening of a show in a gallery there and was told that Buffalo is very interesting for architecture.
By the way Howard, are you from that area of Pa? My son worked on his doctorate in State College. I love the area.