Morocco is a very photogenic place but it is also a difficult place to photograph. The reason is that most tourist areas are full of touts, that is, people trying to be your guide, sell you something or find you a hotel. They can be agressive and persistant. Holding a camera is like a tout magnet. Most times when I was there I didn't get my camera out of its bag. I've got memories but not many photographs.
If you do a google search for "touts Morocco" you will get an idea of what to expect. Different people will have different experiences of a country. I'm just saying in my experience of travelling through 30+ countries in Asia, Europe etc, Morocco was the biggest hassle and the hardest to photograph in. This is my personal experience and you should take it for what it is, that is a request that you research the country before you plan to go.
Cheers,